-
Notifications
You must be signed in to change notification settings - Fork 7.8k
boards: rw612: Fix enablement of XTAL32 Kconfig #93686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -12,3 +12,4 @@ CONFIG_GPIO=y | |||
CONFIG_ARM_MPU=y | |||
CONFIG_HW_STACK_PROTECTION=y | |||
CONFIG_TRUSTED_EXECUTION_SECURE=y | |||
CONFIG_XTAL32K=y |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is it not driven by DT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
cd6560d
to
83e39da
Compare
Switch the XTAL32 configuration from Kconfig to devicetree Signed-off-by: Mahesh Mahadevan <mahesh.mahadevan@nxp.com>
This oscillator has better accuracy and is available by default on this board. Disable this in the ethernet variant where XTAL32 is disconnected so we can use the ethernet pins. Signed-off-by: Mahesh Mahadevan <mahesh.mahadevan@nxp.com>
83e39da
to
54855c9
Compare
|
@@ -5,6 +5,8 @@ | |||
# | |||
|
|||
if(CONFIG_NXP_RW6XX_BOOT_HEADER) | |||
dt_nodelabel(xtal32 NODELABEL "xtal32") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mmahadevan108 ,
i guess &xtal32
node needs add and enable in ubx_evk_iris_w1_common.dtsi
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not enable it in the dtsi as by default xtal32 is not connected and requires a hardware modification.
This what I read on Page 24 of this document: https://content.u-blox.com/sites/default/files/documents/EVK-IRIS-W1_UserGuide_UBX-23007837.pdf .
Please correct me if I am missing something.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mmahadevan108 ,
You’re correct — the 32 kHz crystal isn’t populated by default, so leaving xtal32
disabled in the DTSI is appropriate.
XTAL32 Kconfig was always turned on when using the RTC 1Hz block which is incorrect. This should be dependent on whether this oscillator is enabled to be used.